Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Guard references to Keycloak #231

Merged
merged 2 commits into from
May 19, 2023

Conversation

fabianvf
Copy link
Contributor

@fabianvf fabianvf commented May 17, 2023

This will prevent the playbook from failing when Keycloak is disabled because it is unable to find the Keycloak kind.

Closes #219

I also added skips for the var-naming role prefix ansible-lint rule as that was failing and is not related to this PR

@fabianvf fabianvf force-pushed the check-cluster-apis branch from 39d5573 to 96146cf Compare May 17, 2023 18:35
This will prevent the playbook from failing when Keycloak is disabled
because it is unable to find the Keycloak kind.

Closes konveyor#219

Signed-off-by: Fabian von Feilitzsch <fabian@fabianism.us>
@fabianvf fabianvf force-pushed the check-cluster-apis branch from 96146cf to 4d2ade0 Compare May 17, 2023 18:37
Signed-off-by: Fabian von Feilitzsch <fabian@fabianism.us>
@fabianvf fabianvf force-pushed the check-cluster-apis branch from ea87243 to 0b73bed Compare May 17, 2023 18:49
Copy link
Member

@aufi aufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fabianvf fabianvf merged commit 8999372 into konveyor:main May 19, 2023
jmontleon pushed a commit to jmontleon/tackle2-operator that referenced this pull request May 23, 2023
This will prevent the playbook from failing when Keycloak is disabled
because it is unable to find the Keycloak kind.

Closes konveyor#219

I also added skips for the var-naming role prefix ansible-lint rule as
that was failing and is not related to this PR

---------

Signed-off-by: Fabian von Feilitzsch <fabian@fabianism.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

With auth disabled, operator fails due to missing Keycloak
4 participants