Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(actions): start minikube & install tackle #111

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

djzager
Copy link
Member

@djzager djzager commented Sep 2, 2022

This is the first PR with the goal leveraging GitHub Actions to provide the Konveyor organization with a simple and extensible CI/CD platform. Here is a link to the Google Slides where this was presented in the Konveyor Technical Architecture Forum.

tl;dr

  • This PR introduces 2 GitHub Actions (start-minikube and install-tackle)
  • These actions are run via shell scripts that can be invoked via Makefile for local development
  • Shell scripts are intentionally made to be self-contained (no source utils.sh) and idempotent (kubectl apply instead of kubectl create) to make them useful for local development
  • These actions (and shell scripts) can be re-used in other Tackle projects that need them for testing (ie. tackle2-addon-windup)

The end goal is to make these scripts useful in the typical development workflow to simplify onboarding new contributors by having well used/tested startup scripts.

@djzager djzager force-pushed the ci-actions branch 2 times, most recently from 28832af to 3f1d7f1 Compare September 2, 2022 17:32
@djzager
Copy link
Member Author

djzager commented Sep 2, 2022

I figure that if I can make these scripts work on my extremely slow network. It should be ready for primetime 😎

@djzager djzager force-pushed the ci-actions branch 2 times, most recently from f1c60c2 to c7bc50d Compare September 2, 2022 19:03
@fbladilo
Copy link
Contributor

fbladilo commented Sep 7, 2022

@djzager They look good assuming they've gotten a good round of testing , I have these questions :

  • We expect these actions to run (at some point) against PRs posted to the main branch in different tackle2 repos (i.e windup, hub)?

If you can summarize the CI idea on a high level it would be helpful in understanding the pieces as they come in and also clarify the overall goal

@fbladilo fbladilo self-requested a review September 7, 2022 12:52
Makefile Show resolved Hide resolved
Re-usable actions suitable for starting minikube and installing tackle.
@djzager djzager requested a review from fbladilo September 7, 2022 16:26
@djzager djzager merged commit 870154f into konveyor:main Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants