Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#94 add width and height to asset #96

Merged

Conversation

SmootherSpike
Copy link

  • fix tests after changes

Motivation

Fixes #94

Checklist

  • Code follows coding conventions held in this repo
  • Automated tests have been added
  • Tests are passing
  • Docs have been updated (if applicable)
  • Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

- fix tests after changes
@petrsvihlik
Copy link
Contributor

thanks, we'll have a look at it soon :)

Copy link
Contributor

@kentico-timothyf kentico-timothyf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes to code work. also the additions to the test and sample asset are very welcome!

@kentico-timothyf
Copy link
Contributor

approving changes - will fix CI builds in another PR as they are not caused by this PR, pre-existing issues

Thanks for the PR @SmootherSpike !

@kentico-timothyf kentico-timothyf merged commit 2c39d58 into kontent-ai:master Jan 31, 2020
@SmootherSpike
Copy link
Author

SmootherSpike commented Jan 31, 2020

@petrsvihlik @kentico-timothyf Is there already a new version with these changes available?

@kentico-timothyf
Copy link
Contributor

@SmootherSpike no, I am going to be working on fixing some issues with tests today and will release a new version, hopefully by end of day 01/31

@SmootherSpike
Copy link
Author

Any update on the version so far? it is now a week ago, since last comment

@kentico-timothyf
Copy link
Contributor

@SmootherSpike I had finished the pending PR's and made changes to finalize the rebrand to Kontent, Just waiting on Adam to do the release now, hopefully will happen early this week I will let you know when it happens in case you miss it!

@SmootherSpike
Copy link
Author

@kentico-timothyf @petrsvihlik Any update for a new version, since it is a couple of days right now?

@aweigold
Copy link
Contributor

@SmootherSpike I published to nexus last night, should be there. I gave @kentico-timothyf detailed instructions on how to release as well, and will leave it up to him and @petrsvihlik for release announcements.

@kentico-timothyf
Copy link
Contributor

@aweigold thanks for the release! we will do the announcement as soon as everything has propagated to the proper channels so that it shows up everywhere we expect it to, in the meantime @SmootherSpike you can still utilize the release as it is already showing in maven: https://oss.sonatype.org/content/groups/public/com/github/kentico/kontent-delivery/3.1.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Width and Height of Asset model missing
4 participants