-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#94 add width and height to asset #96
#94 add width and height to asset #96
Conversation
- fix tests after changes
thanks, we'll have a look at it soon :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes to code work. also the additions to the test and sample asset are very welcome!
approving changes - will fix CI builds in another PR as they are not caused by this PR, pre-existing issues Thanks for the PR @SmootherSpike ! |
@petrsvihlik @kentico-timothyf Is there already a new version with these changes available? |
@SmootherSpike no, I am going to be working on fixing some issues with tests today and will release a new version, hopefully by end of day 01/31 |
Any update on the version so far? it is now a week ago, since last comment |
@SmootherSpike I had finished the pending PR's and made changes to finalize the rebrand to Kontent, Just waiting on Adam to do the release now, hopefully will happen early this week I will let you know when it happens in case you miss it! |
@kentico-timothyf @petrsvihlik Any update for a new version, since it is a couple of days right now? |
@SmootherSpike I published to nexus last night, should be there. I gave @kentico-timothyf detailed instructions on how to release as well, and will leave it up to him and @petrsvihlik for release announcements. |
@aweigold thanks for the release! we will do the announcement as soon as everything has propagated to the proper channels so that it shows up everywhere we expect it to, in the meantime @SmootherSpike you can still utilize the release as it is already showing in maven: https://oss.sonatype.org/content/groups/public/com/github/kentico/kontent-delivery/3.1.0/ |
Motivation
Fixes #94
Checklist