Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kotlin sample app #114

Merged
merged 10 commits into from
Oct 20, 2020
Merged

Kotlin sample app #114

merged 10 commits into from
Oct 20, 2020

Conversation

Simply007
Copy link
Contributor

Motivation

Kotlin sample app showcasing Kotlin coroutines with Kentico Kontent Delivery SDK.

Related to #113

Checklist

  • Code follows coding conventions held in this repo
  • Automated tests have been added
  • Tests are passing
  • Docs have been updated (if applicable)
  • Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test

If manual testing is required, what are the steps?

@Simply007 Simply007 marked this pull request as ready for review October 16, 2020 13:34
@Simply007
Copy link
Contributor Author

Simply007 commented Oct 16, 2020

After merge:

  1. release beta of the deliverySDK
  2. @makma - check if the delivery SDK is working
    • Strongly type converter was changed
    • Thymeleaf configuration
    • commits c8729c0 c8e04cb
  3. release final

@Simply007 Simply007 requested a review from makma October 16, 2020 13:41
makma
makma previously approved these changes Oct 20, 2020
Copy link

@makma makma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Simply007, this looks great. I've checked the code with reamdes. Moreover, I've tried to run the android app with the provided SDK. Dev experience was really great.

sample-app-android-kotlin/README.md Outdated Show resolved Hide resolved
Co-authored-by: Martin Makarský <martinm@kentico.com>
@Simply007 Simply007 merged commit 3fb36da into master Oct 20, 2020
@Simply007 Simply007 deleted the kotlin-showcase branch October 20, 2020 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants