Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Page.nextPage() fails with NPE #59

Closed
aweigold opened this issue Apr 1, 2018 · 6 comments
Closed

Page.nextPage() fails with NPE #59

aweigold opened this issue Apr 1, 2018 · 6 comments
Assignees
@aweigold
Labels
good first issue

Comments

@aweigold
Copy link
Contributor

aweigold commented Apr 1, 2018

The DeliveryClient does not set the stronglyTypedContentItemConverter on the ContentItemsListingResponse on calls to getPageOfItems and getNextPage causing the constructor of the new Page to throw an NPE when it invokes to response.castTo(tClass).
@krisctl
Copy link

krisctl commented Apr 19, 2018

Hi,

Looking to contribute to this project. Can someone please assign this issue to me?

Thanks,
Krishan

@petrsvihlik
Copy link
Contributor

Hi @Krishan-Sharma, we appreciate that! Please accept the collaborator invitation I've just sent you and I'll be able to assign the issue to you :)

@krisctl
Copy link

krisctl commented Apr 21, 2018

Thanks, @petrsvihlik. I have accepted the invitation. I am contributing to OSS for the first time. Would there be some documentation other than the code of conduct that I can follow for contributing to this project and if yes, can you please help me with that?

Thanks,
Krishan

@petrsvihlik
Copy link
Contributor

Hi @Krishan-Sharma absolutely!

You can read the general contributing guidelines and if you're not familiar with contributing on GitHub you can watch this video. It's from a different project of ours but the second part (6min 24sec+) applies to all our projects. It'll guide you step by step through the GitHub flow...

Let me know if you have any specific questions, otherwise just submit a pull request and we'll take a look at it promptly and give you feedback :) Good Luck!

@aweigold
Copy link
Contributor Author

Hi @Krishan-Sharma , sorry for my lack of response, I was on vacation. If you need any help, feel free to reach out to me, and thanks for the offer to help!

@aweigold aweigold assigned aweigold and unassigned krisctl Jul 28, 2018
aweigold added a commit that referenced this issue Jul 28, 2018
@aweigold
* Changing artifact name from 'delivery-sdk-java' to 'delivery'.
7d72733 
* Updating Gradle to 4.9.
* Updating build scripts.
* Removing IntelliJ Idea files due to sync issues. (these are generated)
* Removing Android POC, please use com.kenticocloud:delivery-android.
* #58 added to README.md `DeliveryOptions` method for secure access.
* #59 fixing NPE.
@aweigold
Copy link
Contributor Author

This has been fixed in 2.0.0-SNAPSHOT. Closing issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aweigold aweigold

Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aweigold @krisctl @petrsvihlik