Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ruby <= 2.2 false timeout on EOF #4

Merged
merged 4 commits into from
Jul 21, 2017
Merged

Fix ruby <= 2.2 false timeout on EOF #4

merged 4 commits into from
Jul 21, 2017

Conversation

SpComb
Copy link
Contributor

@SpComb SpComb commented Jul 21, 2017

Use IO.select instead of wait_readable on ruby <= 2.2, as it returns nil on EOF: ruby/ruby@a60e00f

@SpComb SpComb added the bug label Jul 21, 2017
@SpComb SpComb merged commit a4e2a28 into master Jul 21, 2017
@SpComb SpComb deleted the fix/ruby-wait-readable-eof branch July 21, 2017 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@SpComb