Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dacite is requiring dataclasses a dependency. Dataclasses is a root python module and is included with python. Using version
0.0.25
may result in including a version of dataclasses that is incompatible with the most recent version of the typings module.The python version check here was meant to only include dataclasses if the python version was
<3.7.0
. But doing this version check in pip is unreliable, and results in including the dataclasses package even when using python>=3.7.0
.Attempts to use
python3.7 -m pip
does not work.These lines should be removed. Anyone using python
<3.7.0
must pin to an older version of dacite or upgrade.