-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore(RELEASE-523): Rename ServiceAccount field to ServiceAccountName #483
Conversation
Skipping CI for Draft Pull Request. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #483 +/- ##
=======================================
Coverage 84.07% 84.07%
=======================================
Files 26 26
Lines 1488 1488
=======================================
Hits 1251 1251
Misses 169 169
Partials 68 68 ☔ View full report in Codecov by Sentry. |
/test all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was expecting to see some crd changes, but maybe I am wrong. Did you run make generate manifests
before uploading?
I just re-ran, and it updated the CRD. |
This commit updates the 'Pipeline' struct by renaming the 'ServiceAccount' field to 'ServiceAccountName'. Signed-off-by: Sean Conroy <sconroy@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This commit updates the 'Pipeline' struct by renaming the 'ServiceAccount' field to 'ServiceAccountName'.
Jira: Link
Changes: