Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore(RELEASE-523): Rename ServiceAccount field to ServiceAccountName #483

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Chore(RELEASE-523): Rename ServiceAccount field to ServiceAccountName #483

merged 1 commit into from
Jun 18, 2024

Conversation

seanconroy2021
Copy link
Member

@seanconroy2021 seanconroy2021 commented Jun 17, 2024

This commit updates the 'Pipeline' struct by renaming the 'ServiceAccount' field to 'ServiceAccountName'.

Jira: Link

Changes:

  • Renamed 'ServiceAccount' field to 'ServiceAccountName' in the Pipeline struct.

Copy link

openshift-ci bot commented Jun 17, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@seanconroy2021 seanconroy2021 changed the title WIP:feat(RELEASE-523): Rename ServiceAccount field to ServiceAccountName WIP:Chore(RELEASE-523): Rename ServiceAccount field to ServiceAccountName Jun 17, 2024
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.07%. Comparing base (9b8a9a7) to head (a019934).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #483   +/-   ##
=======================================
  Coverage   84.07%   84.07%           
=======================================
  Files          26       26           
  Lines        1488     1488           
=======================================
  Hits         1251     1251           
  Misses        169      169           
  Partials       68       68           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seanconroy2021
Copy link
Member Author

/test all

@seanconroy2021 seanconroy2021 changed the title WIP:Chore(RELEASE-523): Rename ServiceAccount field to ServiceAccountName Chore(RELEASE-523): Rename ServiceAccount field to ServiceAccountName Jun 17, 2024
@seanconroy2021 seanconroy2021 marked this pull request as ready for review June 17, 2024 17:03
@seanconroy2021 seanconroy2021 requested a review from a team as a code owner June 17, 2024 17:03
Copy link
Collaborator

@johnbieren johnbieren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was expecting to see some crd changes, but maybe I am wrong. Did you run make generate manifests before uploading?

tekton/utils/pipeline.go Outdated Show resolved Hide resolved
@seanconroy2021
Copy link
Member Author

seanconroy2021 commented Jun 18, 2024

I was expecting to see some crd changes, but maybe I am wrong. Did you run make generate manifests before uploading?

I just re-ran, and it updated the CRD.

This commit updates the 'Pipeline' struct by renaming the
'ServiceAccount' field to 'ServiceAccountName'.

Signed-off-by: Sean Conroy <sconroy@redhat.com>
@openshift-ci openshift-ci bot added the lgtm label Jun 18, 2024
Copy link
Collaborator

@theflockers theflockers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants