issues/316: Do not duplicate logID #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
komuw
commented
Jul 9, 2023
log/log_test.go
Outdated
|
|
||
| newId := "NEW-id-adh4e92427dajd" | ||
| ctx = context.WithValue(ctx, octx.LogCtxKey, newId) | ||
| l.ErrorCtx(ctx, "hey2", errors.New("badTingOne")) | ||
| l.ErrorCtx(ctx, "hey2", "err2", errors.New("badTingTwo")) | ||
| fmt.Println("\n\t ", w.String(), "\n.") |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #317 +/- ##
==========================================
+ Coverage 74.14% 74.15% +0.01%
==========================================
Files 43 43
Lines 4861 4863 +2
==========================================
+ Hits 3604 3606 +2
Misses 1009 1009
Partials 248 248
☔ View full report in Codecov by Sentry. |
komuw
added a commit
that referenced
this pull request
Jul 10, 2023
- Some logID's are still duplicated, but not all. See the testcase added. It is kind of hard and non-perfomant[2] to try remove all duplicates. 1. Fixes: #316 2. golang/go#56345 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the testcase added.