Skip to content

Conversation

@AlanAlvarez21
Copy link
Contributor

Added orchestrator logic to manage and execute scheduled scripts based on time intervals, specific times, and days. Includes a manager class to handle the execution flow and corresponding tests.

@AlanAlvarez21 AlanAlvarez21 marked this pull request as draft February 1, 2025 01:58
@AlanAlvarez21 AlanAlvarez21 force-pushed the orchestrator-cleanup branch 2 times, most recently from bd210a9 to fc7cb46 Compare February 4, 2025 14:45
@coveralls
Copy link

coveralls commented Feb 4, 2025

Pull Request Test Coverage Report for Build 13204494497

Details

  • 92 of 108 (85.19%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.5%) to 98.502%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/bas/orchestrator/manager.rb 31 47 65.96%
Totals Coverage Status
Change from base Build 13143684592: -1.5%
Covered Lines: 1052
Relevant Lines: 1068

💛 - Coveralls

@AlanAlvarez21 AlanAlvarez21 marked this pull request as ready for review February 4, 2025 14:54
@AlanAlvarez21 AlanAlvarez21 linked an issue Feb 4, 2025 that may be closed by this pull request
@AlanAlvarez21 AlanAlvarez21 marked this pull request as draft February 4, 2025 20:06
@AlanAlvarez21 AlanAlvarez21 force-pushed the orchestrator-cleanup branch 2 times, most recently from 026782d to e33ee9f Compare February 5, 2025 19:10
@AlanAlvarez21 AlanAlvarez21 marked this pull request as ready for review February 5, 2025 19:12
@AlanAlvarez21 AlanAlvarez21 force-pushed the orchestrator-cleanup branch 2 times, most recently from e07fe07 to 64f7d66 Compare February 5, 2025 19:43
Copy link
Member

@L-Zuluaga L-Zuluaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some suggestions, but overall everything looks good, lets see if @FelipeGuzmanSierra has additional comments for you

Copy link
Collaborator

@FelipeGuzmanSierra FelipeGuzmanSierra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments, let me know if you want to discuss them!

@AlanAlvarez21 AlanAlvarez21 force-pushed the orchestrator-cleanup branch 2 times, most recently from 3b0390a to a1e263a Compare February 6, 2025 20:42
@AlanAlvarez21
Copy link
Contributor Author

Fixed implemented ! @L-Zuluaga @FelipeGuzmanSierra Thanks!

@L-Zuluaga
Copy link
Member

@AlanAlvarez21 Latest commits aren't correctly signed
image

@AlanAlvarez21
Copy link
Contributor Author

@AlanAlvarez21 Latest commits aren't correctly signed image

fixed @FelipeGuzmanSierra ,

Copy link
Member

@L-Zuluaga L-Zuluaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlanAlvarez21 AlanAlvarez21 merged commit 9fa822a into main Feb 7, 2025
4 checks passed
@AlanAlvarez21 AlanAlvarez21 deleted the orchestrator-cleanup branch February 7, 2025 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Orchestator definition

5 participants