upgrade watchdog service to scheduled task #1951
Conversation
| // RunWatchdogTask is typically run as a check to determine the health of launcher and restart if required. | ||
| // it is installed as an exec action via windows scheduled task. e.g. C:\path\to\launcher.exe watchdog -config <path>. | ||
| // you can alternatively run this subcommand to install or remove the scheduled task via the --install-task or --remove-task flags | ||
| func RunWatchdogTask(systemSlogger *multislogger.MultiSlogger, args []string) error { |
There was a problem hiding this comment.
note that this file was renamed and looks new but most of what has changed here is just the options parsing logic. the rest is a much simpler version (no power event watching, no polling) of what the service version did before
…ations and cleanup
zackattack01
force-pushed
the
zack/scheduled_tasks
branch
from
189035c
to
7af2d45
Compare
| binDirBase = fmt.Sprintf(`C:\Program Files\Kolide\Launcher-%s\bin`, identifier) | ||
| launcherExeName = "launcher.exe" | ||
| default: | ||
| binDirBase = fmt.Sprintf(`/usr/local/%s/bin`, identifier) |
There was a problem hiding this comment.
Ahhh can you throw a quick comment here or in the docblock that this won't work for NixOS, just so we don't forget if we try to use it for Linux in the future?
There was a problem hiding this comment.
ahh yep! or do you think it make more sense to just add this to pkg_utils_windows.go? it is only in use for these windows tasks currently
There was a problem hiding this comment.
added a comment but happy to move this over if you think that's more appropriate
…alLauncherExecutablePath
The current watchdog implementation installs a lightweight service to periodically check the launcher's service state, and restart if required. The main issue we've found with this in testing is that this service is subject to many of the same power management/sleep state transitions issues that impact the launcher service itself.
These changes alter this pattern to instead utilize a short-lived task that will perform the same state checking and restarts, driven instead by the windows task scheduler service. This is beneficial for a few reasons:
We still make use of much of the same log buffering, service restart, and controller + flag logic that was initially added for watchdog. This primarily includes the following changes:
--install-taskand--remove-taskoptions to the watchdog subcommand, this was something I had wanted for the original watchdog and it should allow us to easily install or remove on demand while testing