-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove and consolidate osquery instance options #1909
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Always love negative lines of code. Do any of these removals make options in launcher options obsolete?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't test this, but I imagine it's fine.
However I think we should hold slightly on merging -- I think we're going to want to be in a place to cut a release for Zack's flare stuff and maybe the systray tweaks.
@directionless good point -- converted to draft and will hold off on merging. @James-Pickett checked and yes! Deprecated a handful of flags. 🎉 |
Relates to #1827 -- getting some tidying out of the way before making more substantial changes.
Relates to #1936.
This PR updates our osquery instance options:
While I was validating that the root directory will always be set by the time that we make it to the osquery runner, I noticed that in
runLauncher
if the root directory wasn't set in the launcher options and we fell back to making a temp directory, we wouldn't save that temp directory in the knapsack flags. I updated to save it in the launcher options, so that it would later be available via the knapsack. I imagine we don't run into this issue much/at all, but wanted to address it just in case.