Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use latest systray to hide until ready #1885

Merged
merged 2 commits into from
Oct 11, 2024
Merged

use latest systray to hide until ready #1885

merged 2 commits into from
Oct 11, 2024

Conversation

James-Pickett
Copy link
Contributor

@James-Pickett James-Pickett commented Oct 11, 2024 •
edited
Loading

  • use latest version of systray to hide menu until ready
  • don't execute notifications until showing systray
  • don't execute universal link handler until using systray
  • don't try to send notifications if desktop not enabled

@James-Pickett James-Pickett marked this pull request as ready for review October 11, 2024 15:26
@James-Pickett James-Pickett added this pull request to the merge queue Oct 11, 2024
Merged via the queue into kolide:main with commit 100a084 Oct 11, 2024
26 of 29 checks passed
@James-Pickett James-Pickett deleted the james/desktop-fixes branch October 11, 2024 15:54
@RebeccaMahany RebeccaMahany added the bug-fixes Bug Fixes label Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zackattack01 zackattack01 zackattack01 approved these changes

@RebeccaMahany RebeccaMahany RebeccaMahany approved these changes

Assignees
No one assigned
Labels
bug-fixes Bug Fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@James-Pickett @RebeccaMahany @zackattack01