Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade actions to versions that run on node20 #1771

Merged
merged 9 commits into from
Jul 8, 2024

Conversation

RebeccaMahany
Copy link
Contributor

@RebeccaMahany RebeccaMahany commented Jul 3, 2024

I saw we were getting lots of warnings in our CI jobs like:

The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3, actions/setup-go@v3, actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

This PR upgrades all actions to versions that run on node20, to make these warnings go away.

Upgrading actions/upload-artifact is additionally useful because actions/upload-artifact@v3 is set to be deprecated toward the end of this year.

No more warnings:

@RebeccaMahany RebeccaMahany changed the title Becca/node 20 Upgrade actions to versions that run on node20 Jul 3, 2024
directionless
directionless previously approved these changes Jul 5, 2024
directionless
directionless previously approved these changes Jul 8, 2024
@RebeccaMahany RebeccaMahany marked this pull request as ready for review July 8, 2024 19:25
@RebeccaMahany RebeccaMahany added this pull request to the merge queue Jul 8, 2024
Merged via the queue into kolide:main with commit 07a5339 Jul 8, 2024
31 checks passed
@RebeccaMahany RebeccaMahany deleted the becca/node-20 branch July 8, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants