Continue in kolide_jwt when rawData is empty #1751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e a fatal error and crash for ErrTokenMalformed
Micah-Kolide
force-pushed
the
micah/jwt_continue_if_no_data
branch
from
a82e361
to
f1d0884
Compare
RebeccaMahany
approved these changes
Jun 13, 2024
zackattack01
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to pass an empty or null token to the jwt parser will cause a fatal error (
ErrTokenMalformed) and panic (panic: runtime error: invalid memory address or nil pointer dereference). I'm simply checking that therawDatais not of length0, otherwise throw the same error (error reading JWT data file) before trying to hand it off to the jwt parser.Something I should've caught previously, but I did not have a test for it. I do now.