windows root directory fallback #1742
Conversation
zackattack01
force-pushed
the
zack/windows_find_rootdir
branch
from
c94552f
to
8c438e2
Compare
There was a problem hiding this comment.
Thinking out loud... What are the cases:
| db[s] on disk | option | desired outcome |
|---|---|---|
| old location | old location | old location |
| new location | new location | new location |
| new location | old location | new location |
| old location | new location | old location |
| anywhere | developer | developer specified |
cmd/launcher/svc_windows.go
Outdated
| @@ -51,6 +51,18 @@ func runWindowsSvc(systemSlogger *multislogger.MultiSlogger, args []string) erro | |||
|
|
|||
| // Create a local logger. This logs to a known path, and aims to help diagnostics | |||
| if opts.RootDirectory != "" { | |||
| // check for old root directories before creating DB in case we've stomped over with windows MSI install | |||
| updatedRootDirectory := determineRootDirectory(opts.RootDirectory, systemSlogger.Logger) | |||
There was a problem hiding this comment.
I'd use the local/debug slogger, not the system one
There was a problem hiding this comment.
Though I guess this is happening before we know where to write debug.json. Tricky
There was a problem hiding this comment.
yeah my first pass at this failed to notice that and the logs end up being split across RootDirs, I thought maybe safer to just do this until we get it set up
zackattack01
force-pushed
the
zack/windows_find_rootdir
branch
from
1243dab
to
f118073
Compare
| "C:\\ProgramData\\Kolide\\Launcher-kolide-k2\\data", | ||
| "C:\\Program Files\\Kolide\\Launcher-kolide-k2\\data", |
There was a problem hiding this comment.
I think this is the correct order? It means that if there's a new db path, we should prefer it. And I think that's likely to be true if someone got themselves into this situation. (They'll have already done the pain of it, and going back to the old db will be worse)
There was a problem hiding this comment.
that was my thinking as well. I think for most (upgrade) cases moving forward we'll get ProgramData via opts anyway and check that first before we even iterate these
There was a problem hiding this comment.
Mostly talking through my assumptions here.
zackattack01
force-pushed
the
zack/windows_find_rootdir
branch
from
9ecd3c2
to
cdf6a57
Compare
zackattack01
dismissed stale reviews from RebeccaMahany and James-Pickett
via
447fe39
These changes are to allow a windows device to fallback to a historical (or current) root directory location. When an MSI with a different root directory is freshly installed over another, launcher cannot see the existing DB and triggers a new enrollment.
To avoid this, svc_windows will override the root_directory set by the MSI if a populated database exists in another known root directory location