do not pre-create data files in wix for uninstall cleanup #1738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure I quite understand what this will do. Can you make a table of the various install/uninstall pairs? Or I don't quite know what? |
directionless
approved these changes
Jun 6, 2024
There was a problem hiding this comment.
Okay, I talked to Zack about this.
Our current understanding is that a lot of MSI upgrade/downgrade/repair behaviors work by first triggering an msi uninstall. In those cases we do not want to uninstall the database.
And while we do want to uninstall, on balance, it's worse than removing the DB on upgrades.
RebeccaMahany
approved these changes
Jun 6, 2024
James-Pickett
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain data directory files are pre-created as empty files during wix packaging, to ensure that these are cleaned up on uninstall.
However some deployments forcibly re-install a new MSI outside of the autoupdate flow. This will trigger the uninstall first, which is now able to remove those files, leaving the device in an unenrolled state