Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call AttachConsole for better output on Windows #1438

Merged
merged 7 commits into from
Nov 7, 2023

Conversation

RebeccaMahany
Copy link
Contributor

@RebeccaMahany RebeccaMahany commented Nov 3, 2023

Closes #1433

Fixes writing output to the terminal for:

  • doctor
  • flare
  • version
  • svc-fg

@RebeccaMahany RebeccaMahany changed the title Call AttachConsole from doctor for better output on Windows Call AttachConsole for better output on Windows Nov 6, 2023
Copy link
Contributor

@directionless directionless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, happy to try!

@RebeccaMahany RebeccaMahany added this pull request to the merge queue Nov 7, 2023
Merged via the queue into kolide:main with commit f8222fa Nov 7, 2023
24 checks passed
@RebeccaMahany RebeccaMahany deleted the becca/attach-console branch November 7, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

launcher doctor output looks malformed on Windows
3 participants