Fix Sonoma issues with the build #1424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've been seeing build issues with modern Xcode. In theory they should have been fixed with go 1.21, but it's not clear that code merged. So, this is a simple hammer. It defines some acceptable warnings, and then doesn't exit of those are the only things in stderr.
pkg/make/builder.go
Outdated
| stderrStr = strings.ReplaceAll(stderrStr, "ld: warning: ignoring duplicate libraries: '-lobjc'\n", "") | ||
| stderrStr = strings.ReplaceAll(stderrStr, "# github.com/kolide/launcher/cmd/launcher\n", "") | ||
|
|
||
| re := regexp.MustCompile(`ld: warning: object file \(.*\) was built for newer 'macOS' version \(14.0\) than being linked \(11.0\)\n`) |
There was a problem hiding this comment.
do we want to make this one any more flexible with the version numbers? just wondering if it will still work for those who haven't upgraded yet
There was a problem hiding this comment.
🤷 We could. Though I hope it's fixed by then.
There was a problem hiding this comment.
same 🙏 I just wasn't sure if we were seeing 13.0 before this, I thought mine started earlier than the upgrade
There was a problem hiding this comment.
I still get the error sometimes and I'm on Ventura still, I don't know how to repro it
Co-authored-by: Rebecca Mahany-Horton <rebeccamahany@gmail.com>
zackattack01
approved these changes
Oct 26, 2023
RebeccaMahany
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been seeing build issues with modern Xcode. In theory they should have been fixed with go 1.21, but it's not clear that code merged. So, this is a simple hammer.
It defines some acceptable warnings, and then doesn't exit of those are the only things in stderr.
Closes #1423