Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log checkpoint followup + dns checkup tests #1410

Merged
merged 9 commits into from
Oct 17, 2023
Merged

log checkpoint followup + dns checkup tests #1410

merged 9 commits into from
Oct 17, 2023

Conversation

zackattack01
Copy link
Contributor

This adds cleanup and some tests to the ongoing log checkpoint efforts. Most cleanup is based on prior feedback, notably:

  • use jsonlogger instead of fmtlogger to allow us to let the logger handle nested formatting
  • simplify the pre-processing and return to Data() any signature for the checkup interface
  • move the server_data checkup logic to use ServerProvidedDataStore instead of bbolt directly
  • renaming checkpointer and existing test vars for clarity/consistency

RebeccaMahany
RebeccaMahany reviewed Oct 17, 2023
View reviewed changes
Copy link
Contributor

@RebeccaMahany RebeccaMahany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup + thanks for building out the tests

pkg/debug/checkups/connectivity.go Outdated Show resolved Hide resolved
pkg/debug/checkups/dns.go Show resolved Hide resolved
pkg/debug/checkups/checkpoint.go Outdated Show resolved Hide resolved
cmd/launcher/launcher.go Outdated Show resolved Hide resolved
@zackattack01 zackattack01 added this pull request to the merge queue Oct 17, 2023
Merged via the queue into main with commit 2ff8061 Oct 17, 2023
26 checks passed
@zackattack01 zackattack01 deleted the zack/log_checkpoint_followup branch October 17, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@directionless directionless directionless left review comments

@RebeccaMahany RebeccaMahany RebeccaMahany approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zackattack01 @directionless @RebeccaMahany