Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add running user in debug upload request, unexport flare env type #1400

Merged

Conversation

James-Pickett
Copy link
Contributor

No description provided.

@James-Pickett James-Pickett changed the title add running user in upload request, unexport type add running user in debug upload request, unexport type Oct 12, 2023
@James-Pickett James-Pickett changed the title add running user in debug upload request, unexport type add running user in debug upload request, unexport flare env type Oct 12, 2023
@James-Pickett James-Pickett marked this pull request as ready for review October 12, 2023 22:02
Copy link
Contributor

@directionless directionless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable!

Do you think this should go into a checkup, or stay here in the shipper? Approved if you want it here

@James-Pickett
Copy link
Contributor Author

Seems reasonable!

Do you think this should go into a checkup, or stay here in the shipper? Approved if you want it here

I will leave this in the shipper as this is the data sent to server when requesting a url for flare upload.

@James-Pickett James-Pickett added this pull request to the merge queue Oct 17, 2023
Merged via the queue into kolide:main with commit cbf10ae Oct 17, 2023
27 checks passed
@James-Pickett James-Pickett deleted the james/flare-shipping-tweaks branch October 17, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants