Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the initial osquery --version to using runsimple #1379

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Move the initial osquery --version to using runsimple #1379

merged 1 commit into from
Oct 3, 2023

Conversation

directionless
Copy link
Contributor

@directionless directionless commented Oct 3, 2023 •
edited
Loading

With #1213 merged, it seemed easy to move this osquery exec to runsimple. Seems to work on my local dev environment:

{"caller":"launcher.go:512","component":"osquery-version-check","execution_time_ms":116,"msg":"checked osqueryd version","session_pid":60777,"severity":"debug","ts":"2023-10-03T19:03:12.643667Z","version":"osqueryd version 5.8.1"}

@directionless directionless marked this pull request as ready for review October 3, 2023 19:08
@directionless
Copy link
Contributor Author

I think this is okay for 1.1.2, so I'm merging

@directionless directionless added this pull request to the merge queue Oct 3, 2023
Merged via the queue into kolide:main with commit 4df0fd3 Oct 3, 2023
25 checks passed
@directionless directionless deleted the seph/osq-version branch October 3, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RebeccaMahany RebeccaMahany RebeccaMahany approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@directionless @RebeccaMahany