Replace altool with notarytool #1258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RebeccaMahany
force-pushed
the
becca/altool-deprecation
branch
from
9c0005e
to
98e346c
Compare
|
|
||
| // Falling out of the for loop means we never succeeded | ||
| return "", errors.New("Did not successfully submit for notarization") | ||
| return n.runNotarytool(ctx, filePath) |
There was a problem hiding this comment.
using Altool we had some retry logic, is notary tool more stable?
There was a problem hiding this comment.
I think so? In test, I didn't see it fail, and I took guidance from endpoint-releaser, where we also don't use a retry with notarytool.
James-Pickett
previously approved these changes
Jul 20, 2023
directionless
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to: #1257
altool will be deprecated this November; this PR updates to use notarytool instead.