Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

james/accelerate control via control update #1250

Merged
merged 22 commits into from
Aug 23, 2023
Merged

james/accelerate control via control update #1250

merged 22 commits into from
Aug 23, 2023

Conversation

James-Pickett
Copy link
Contributor

@James-Pickett James-Pickett commented Jul 11, 2023 •
edited
Loading

  • adds action queue layer to handle actions from control server
  • updates notification consumer to use action queue
  • adds actor for handling control server acceleration actions

closes https://github.com/orgs/kolide/projects/13/views/1?pane=issue&itemId=28576526

RebeccaMahany
RebeccaMahany reviewed Jul 21, 2023
View reviewed changes
Copy link
Contributor

@RebeccaMahany RebeccaMahany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how you've expanded this! 🔥

ee/control/actionqueue/actionqueue.go Outdated Show resolved Hide resolved
ee/control/actionqueue/actionqueue.go Outdated Show resolved Hide resolved
ee/control/actionqueue/actionqueue.go Show resolved Hide resolved
ee/control/actionqueue/actionqueue.go Outdated Show resolved Hide resolved
ee/control/actionqueue/actionqueue_test.go Outdated Show resolved Hide resolved
ee/control/actionqueue/actionqueue_test.go Outdated Show resolved Hide resolved
ee/control/consumers/acceleratecontrolconsumer/acceleratecontrolconsumer.go Outdated Show resolved Hide resolved
@James-Pickett James-Pickett reopened this Aug 1, 2023
@James-Pickett James-Pickett marked this pull request as ready for review August 1, 2023 20:02
@RebeccaMahany
Copy link
Contributor

LGTM -- happy to approve when you've decided on #1250 (comment)?

@directionless
Copy link
Contributor

directionless commented Aug 8, 2023 •
edited
Loading

Please hold on merging. I suspect we're going to cut an 1.0.15 RSN.

RebeccaMahany
RebeccaMahany approved these changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@RebeccaMahany RebeccaMahany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! LGTM

@James-Pickett James-Pickett merged commit 77b02fa into kolide:main Aug 23, 2023
26 checks passed
@James-Pickett James-Pickett deleted the james/accelerate-control-via-control-update branch August 23, 2023 15:17
@James-Pickett James-Pickett mentioned this pull request Aug 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RebeccaMahany RebeccaMahany RebeccaMahany approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@James-Pickett @RebeccaMahany @directionless