[OpenTelemetry] osquery-go trace instrumentation #1244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y-extension-client
…y-extension-client
…y-extension-client
…ry-trace-instrumentation
RebeccaMahany
force-pushed
the
becca/osquery-trace-instrumentation
branch
from
ee36a6d
to
6e65358
Compare
James-Pickett
approved these changes
Jul 10, 2023
directionless
approved these changes
Jul 10, 2023
| @@ -15,6 +15,7 @@ import ( | |||
| "github.com/kolide/launcher/pkg/agent/types" | |||
| "github.com/kolide/launcher/pkg/backoff" | |||
| "github.com/kolide/launcher/pkg/osquery" | |||
| osquerygotraces "github.com/osquery/osquery-go/traces" | |||
There was a problem hiding this comment.
Seeing this, makes me think we should put SetTracerProvider to being in the toplevel osquery-go library. and leave traces as effectively internal. But 🤷 maybe not important
There was a problem hiding this comment.
I don't feel strongly about it either way
There was a problem hiding this comment.
I don't think it's worth fixing now, but it feels wrong. traces should really be an internal package, not part of the exposed API surface. But 🤷 we're most of the users, and I don't feel like we need to maintain some high standard of API consistency, so not worth it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulls in changes from osquery/osquery-go#110 and adds a small amount of instrumentation to trace codepaths from osquery-go to launcher and vice versa.
Screenshots below --
Call => Distributed => GetQueries
Call => Config
Call => Table => exec