Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TUF autoupdater] Include arch in release file path and download file path #1195

Merged

Conversation

RebeccaMahany
Copy link
Contributor

Relates to #1149, #954.

seejdev
seejdev previously approved these changes May 12, 2023
@RebeccaMahany
Copy link
Contributor Author

Waiting until we've published at least one osquery release (now that changes in #1149 have been merged) to merge this

@jaredallard
Copy link

Sorry to ping on this, but is there any news of when this would be? We're looking to run this on linux/arm64 and it seems like it's so close! @RebeccaMahany 🙏

@RebeccaMahany
Copy link
Contributor Author

@jaredallard Apologies for the delay on the response, I missed this! I'll be getting this PR through today since we've had a new osquery release -- however, the larger issue #1149 is also tied to an in-progress autoupdate rewrite #954 that I anticipate taking a little bit more time. I'll get #954 updated so that it'll be easier to follow it/track the status.

@RebeccaMahany RebeccaMahany marked this pull request as ready for review June 29, 2023 16:34
Copy link
Contributor

@directionless directionless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable.

I think all the path generation is hard to follow. I don't have an easy suggestion for a fix, though. I think over in the MirrorTool library, that's probably why I ended up with the abstraction I did -- so the objects can generate their own paths. But I'm not sure to easily apply that here.

pkg/autoupdate/tuf/library_manager.go Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants