Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set root directory to temp directory if not provided #1191

Merged
merged 1 commit into from
May 9, 2023

Conversation

RebeccaMahany
Copy link
Contributor

Fixes issue where if root dir is not provided, we correctly make a temporary directory to use as the root directory, but do not save the value and promptly try to make a directory with path "":

{"caller":"launcher.go:97","msg":"using default system root directory","path":"/var/folders/0d/l0cmv9pd4qd3j0d98q1st9bm0000gn/T/launcher-root3415220570","severity":"info","ts":"2023-05-09T19:09:56.293064Z"}
{"caller":"main.go:112","creating root directory: mkdir : no such file or directory":"run launcher","severity":"debug","stack":"creating root directory: mkdir : no such file or directory","ts":"2023-05-09T19:09:56.293091Z"}
{"caller":"logutil.go:13","creating root directory: mkdir : no such file or directory":"run launcher","severity":"info","ts":"2023-05-09T19:09:56.293138Z"}

Copy link
Contributor

@directionless directionless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder how long this bug has been there.

@RebeccaMahany RebeccaMahany merged commit 33fab40 into kolide:main May 9, 2023
@RebeccaMahany RebeccaMahany deleted the becca/rootdir branch May 9, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants