Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increasing thrift's ServerConnectivityCheckInterval from 5ms to 100ms #1173

Merged
merged 1 commit into from
May 8, 2023

Conversation

seejdev
Copy link
Contributor

@seejdev seejdev commented May 2, 2023

This changes the Thrift server-side connectivity checks to be 20 times less frequent.

From Thrift documentation:

ServerConnectivityCheckInterval defines the ticker interval used by
connectivity check in thrift compiled TProcessorFunc implementations.

So we have two-way connectivity checks occurring where:

  • Every 5 seconds, launcher osquery client is pinging the osquery Thrift server to check that the osquery process is still running.
  • Every 5 milliseconds, the osquery Thirft server is checking that the socket connected to the client is still open.

Increasing the latency to 100ms seems reasonable.

James-Pickett
James-Pickett previously approved these changes May 2, 2023
Copy link
Contributor

@directionless directionless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try! I don't love the globals, but here we are.

@directionless directionless merged commit 41c7d0f into kolide:main May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants