adds control server acceleartion on menu open event, adds more failsafes for shutting down desktop when parent gone #1159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fes for shutting down desktop when parent gone
James-Pickett
commented
Apr 25, 2023
ee/desktop/runner/server/server.go
Outdated
| r.Body.Close() | ||
| } | ||
|
|
||
| ms.knapsack.SetControlRequestIntervalOverride(5*time.Second, 1*time.Minute) |
There was a problem hiding this comment.
hooray for Knaspsack, it made this part so easy
RebeccaMahany
previously approved these changes
Apr 26, 2023
seejdev
reviewed
Apr 27, 2023
| controlRequestAcclerationDuration = 1 * time.Minute | ||
| ) | ||
|
|
||
| type controlRequestIntervalOverrider interface { |
There was a problem hiding this comment.
Yay, cool to see the knapsack sub-interface in action. This feels clean too
seejdev
reviewed
Apr 27, 2023
| } | ||
|
|
||
| func New(logger log.Logger, controlRequestIntervalOverrider controlRequestIntervalOverrider) (*RunnerServer, error) { | ||
| listener, err := net.Listen("tcp", "localhost:0") |
There was a problem hiding this comment.
Does using port zero mean it will choose a dynamically generated unused port?
There was a problem hiding this comment.
yea, it just picks a random port, it's what the current "monitor server" that is doing now on stable
seejdev
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR repurposes the "monitor_server" that was used only for the desktop user process to check on the root processes' health. The new runner server has an additional endpoint for "menuopened" that the desktop user process can call when it gets a notification from systray that the menu has been opened.
It introduces RunnerServer and renames DesktopServer to UserServer. Both servers are related to the desktop but one is run by the DesktopRunner and one is run by the Desktop User Process.
After this PR merges, I will do some reshuffling of the desktop package structure and put packages into either a
userorrunnerfolder based on their role.It also:
closes: #1155
closes: #1141