Reducing spammy log messages #1153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RebeccaMahany
approved these changes
Apr 24, 2023
| @@ -90,11 +90,6 @@ BOOL doSendNotification(UNUserNotificationCenter *center, NSString *title, NSStr | |||
| BOOL sendNotification(char *cTitle, char *cBody, char *cActionUri) { | |||
| UNUserNotificationCenter *center = [UNUserNotificationCenter currentNotificationCenter]; | |||
|
|
|||
| // To be removed later -- for troubleshooting purposes only | |||
There was a problem hiding this comment.
Oh ha just commented on this -- yep this is fine to remove, thanks for getting it!
James-Pickett
approved these changes
Apr 24, 2023
James-Pickett
pushed a commit
to James-Pickett/launcher
that referenced
this pull request
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up for debate as to whether something else can be done besides eliminating them.
This messages are showing up very frequently in my logs. They are noisy enough that they make observing logging more difficult.