Upgrading gopsutil module to v3 #1133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 17, 2023 08:03
directionless
previously approved these changes
Apr 17, 2023
RebeccaMahany
previously approved these changes
Apr 17, 2023
Co-authored-by: Rebecca Mahany-Horton <rebeccamahany@gmail.com>
seejdev
dismissed stale reviews from RebeccaMahany and directionless
via
0df1045
RebeccaMahany
approved these changes
Apr 17, 2023
James-Pickett
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades the gopsutil dependency to it's latest release, which moves us to the v3 implementation.
The initial impetus for upgrading this was to resolve this annoying build warning:
The only non-trivial change I had to make was accounting for a breaking API change where the
Process.Status()method now returns a slice of strings instead of string. This was very simple, as gopsutil is putting the equivalent value in the first element.