Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kolide_softwareupdate_scan table #1126

Merged
merged 2 commits into from
Apr 12, 2023

Conversation

RebeccaMahany
Copy link
Contributor

@RebeccaMahany RebeccaMahany commented Apr 12, 2023

We are occasionally seeing the new kolide_softwareupdate table return 0 rows from devices who should have a software update available. The explanation appears to be that those devices have not scanned for updates recently -- so this PR adds a second table kolide_softwareupdate_scan that will perform the scan. With this data, hopefully we should be able to determine whether the lack of scan is why kolide_softwareupdate sometimes returns 0 rows when it should return some.

@RebeccaMahany RebeccaMahany changed the title Remove --no-scan from softwareupdate execparser Add kolide_softwareupdate_scan table Apr 12, 2023
Copy link
Contributor

@directionless directionless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the right way is to plumb some options through the exec helper. But this seems like a fine hack

@directionless directionless merged commit 7c6946e into kolide:main Apr 12, 2023
@RebeccaMahany RebeccaMahany deleted the becca/softwareupdate-scan branch April 12, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants