Made relativeTime text output title case to match k2 style #1112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RebeccaMahany
approved these changes
Mar 27, 2023
There was a problem hiding this comment.
I'm wondering for the future if we'd want to think about handling casing entirely on the launcher side -- we could get into the reverse of this situation easily if the text formatting changes on the k2 side. Maybe something to chat about in the future with @blaedj?
I think usually "a" and "in" wouldn't be capitalized in these strings, but it doesn't look like we have a formal style guide at the moment and this is more visually consistent than it was before, so 🚀 🔥
James-Pickett
approved these changes
Mar 27, 2023
Yea, we may want to think about this more in the future, but I think right now this is an improvement over what we had! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made some letters go 🆙