adds logic and endpoint to accelerate control server fetch interval #1105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
James-Pickett
commented
Mar 16, 2023
| @@ -129,8 +129,8 @@ func New(db *bbolt.DB, kolideServer string, opts ...LocalServerOption) (*localSe | |||
| // mux.Handle("/query", ls.requestQueryHandler()) | |||
| // curl localhost:40978/scheduledquery --data '{"name":"pack:kolide_device_updaters:agentprocesses-all:snapshot"}' | |||
| // mux.Handle("/scheduledquery", ls.requestScheduledQueryHandler()) | |||
| // curl localhost:40978/controlservicefetch | |||
| // mux.Handle("/controlservicefetch", ls.requestControlServiceFetch()) | |||
| // curl localhost:40978/acceleratecontrol --data '{"interval":"250ms", "duration":"1s"}' | |||
There was a problem hiding this comment.
@blaedj please see the data in the example curl request here
Is there a standard format for time duration used by k2? or is the go style time.duration good?
There was a problem hiding this comment.
No I don't think there is, we could make the go time.duration style work. This curl example - for 'real' use, we'll be making this request from javascript in the browser, do I understand that correctly?
There was a problem hiding this comment.
cool, thanks! yes, the curl is just an example we use for local testing. The real thing would be in a krypto NaCL box from the JS bridge
seejdev
reviewed
Mar 17, 2023
RebeccaMahany
previously approved these changes
Mar 17, 2023
RebeccaMahany
approved these changes
Mar 17, 2023
seejdev
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.