This repository has been archived by the owner on Dec 15, 2020. It is now read-only.
Implement fleetctl goquery #2186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
zwass
commented
Jan 17, 2020
zwass
commented
- Update fleet APIs to support necessary operations in goquery
- Implement support for goquery in fleetctl
directionless
approved these changes
Jan 21, 2020
| client *service.Client | ||
| queryCounter int | ||
| queries map[string]activeQuery | ||
| // goquery passes the UUID, while we need the hostname (or ID) to |
There was a problem hiding this comment.
I don't know if this is totally right? goquery passes whatever you handed it. So you could hand it a hostname+query id parameter, and it'll pass them back
There was a problem hiding this comment.
As of now goquery uses the UUID of the returned host object to refer to the host later. I discussed with those folks the possibility of goquery using the original identifier, but that has not yet been implemented.
There was a problem hiding this comment.
Yes, it's reused. But, IIRC, it can be whatever you want it to be. A ulid is just a string
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.