This repository has been archived by the owner on Dec 15, 2020. It is now read-only.
Remove Support for Deprecated TLSProfileOld #2142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zwass
reviewed
Nov 11, 2019
It's tricky, yeah? If someone is depending on the behavior of "old" and it changes, is that better than having "old" disappear entirely, break something for someone, but make the change obvious? |
|
I added a deprecation warning for this in #2183 and I think we can merge the removal after the next release goes out with that warning. |
zwass
added a commit
that referenced
this pull request
Jan 14, 2020
Warn users in advance of removing this in #2142.
|
@zwass Can we merge this? The deprecation was introduced in 2.5.0 which has been out for over 6 months. |
|
Yeah, we can merge this now. I'll work on fixing the conflicts. |
cmd/fleet: remove support for deprecated TLSProfileOld
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Go authors deprecated support for SSLv3 in go 1.13. They've decided to remove it in go 1.14, and have already merged the commit.
See: https://golang.org/issue/32716
This PR, or something like it, should probably land before February 2020.