Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support mplayer2 and mpv #2

Closed
Nikoli opened this issue May 6, 2013 · 9 comments
Closed

Support mplayer2 and mpv #2

Nikoli opened this issue May 6, 2013 · 9 comments
Assignees

Comments

@Nikoli
Copy link

Nikoli commented May 6, 2013

Did not find anything about mplayer2 and mpv in git log -p, please add support for them.

@ghost ghost assigned kokoko3k May 6, 2013
@kokoko3k kokoko3k closed this as completed May 6, 2013
@kokoko3k
Copy link
Owner

kokoko3k commented May 6, 2013

As far as i tested, mplayer2 works good.
Could it be that some extra options are not handled directly by xt7, but you can use them by using custom filters and custom options.
For mpv, i didn't even knew it existed; and from what i've read, mpv changes some options naming.
I'm sorry, but i'm not going to add support for mpv.
if you find something specific to mplayer2 that is blocking xt7 from running fine, feel free to open a bug report.

@kokoko3k kokoko3k reopened this May 6, 2013
@kokoko3k kokoko3k closed this as completed May 6, 2013
@Nikoli
Copy link
Author

Nikoli commented Feb 10, 2014

Now mpv has libmpv shared library, what is your opinion about API?
mpv-player/mpv#97 (comment)

@kokoko3k
Copy link
Owner

Sorry for the late answer.
Xt7 uses slave mode to talk to mplayer and mplayer2, which is actually
as simple as writing and reading strings from a pipe.
Actually mpv has a broken slave mode; so i'll consider to support it
when it will work.
Using a shared library would mean to completely rewrite a large
portion of code, and it is something i've no time to do right now,
sorry.

2014-02-10 13:51 GMT+01:00, Nikoli notifications@github.com:

Now mpv has libmpv shared library, what is your opinion about API?
mpv-player/mpv#97 (comment)


Reply to this email directly or view it on GitHub:
#2 (comment)

@Nikoli
Copy link
Author

Nikoli commented Feb 18, 2014

Actually mpv has a broken slave mode; so i'll consider to support it when it will work.

Broken? What do you mean? It works fine, there is even GTK gui using it:
https://github.com/sebadoom/mpvguihs

@kokoko3k
Copy link
Owner

Check by yourself in the man page:
https://github.com/mpv-player/mpv/blob/master/DOCS/man/en/options.rst
search for --slave-broken

2014-02-18 13:21 GMT+01:00, Nikoli notifications@github.com:

Actually mpv has a broken slave mode; so i'll consider to support it
when it will work.

Broken? What do you mean? It works fine, there is even GTK gui using it:
https://github.com/sebadoom/mpvguihs


Reply to this email directly or view it on GitHub:
#2 (comment)

@Nikoli
Copy link
Author

Nikoli commented Feb 18, 2014

They just tell that current mpv slave mode is not as perfect as they desire, it does not mean, that slave mode in mplayer/mplayer2 is somehow better.

@kokoko3k
Copy link
Owner

Please, read better, they say it is currently not compatible with the
old slave mode and that they need a new better one.
They also explicitely state: "This is for testing only"; i fear in
the future they will just drop it and more work will need to be made
to use the new one.

If you really care as it seems, you should really ask mpv devs about
their intentions about that question, i'm certainly not going to
implement something they suggest me not to do.

2014-02-18 15:06 GMT+01:00, Nikoli notifications@github.com:

They just tell that current mpv slave mode is not as perfect as they desire,
it does not mean, that slave mode in mplayer/mplayer2 is somehow better.


Reply to this email directly or view it on GitHub:
#2 (comment)

@kokoko3k kokoko3k reopened this Feb 20, 2015
@kokoko3k
Copy link
Owner

Just to let you know that i'm working on the port since some weeks.
I'm not going to use the slave mode but something near (--input switch)
When ready, i think i'll open a new github page for it (no fork or whatever).
Something like xt7-mpv...

@kokoko3k
Copy link
Owner

kokoko3k commented Mar 3, 2015

@kokoko3k kokoko3k closed this as completed Mar 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants