Introduce Kokkos::Profiling::Region to profile tpl calls #204
+139
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalg24
reviewed
Nov 28, 2024
There was a problem hiding this comment.
I didn't look at all the changes but the one I saw were a better fit for Kokkos::Profiling::ScopedRegion
Thank you for the comments. I was not aware of this. |
rb214678
reviewed
Jan 24, 2025
rb214678
requested changes
Jan 24, 2025
|
@rb214678 Thank you for the review. I have fixed accordingly. |
rb214678
approved these changes
Jan 27, 2025
rb214678
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #201
In this PR, we introduce
Kokkos::Profiling::pushRegion