Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

non-contiguous Impl::irecv #32

Closed
wants to merge 34 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
3624a5a
KokkosComm::irecv
cwpearson Mar 25, 2024
d45bf65
docs: update KokkosComm::Req
cwpearson Mar 26, 2024
5eddb34
add Invokable concept
cwpearson Mar 26, 2024
6815a0c
Req: use Invokable
cwpearson Mar 26, 2024
1c5859f
unit_tests: enable IsendIrecv mdspan tests
cwpearson Mar 26, 2024
63bcfe0
rename Req members
cwpearson Mar 26, 2024
95641b1
revert drop_at_wait back to keep_until_wait
cwpearson Mar 27, 2024
64b20d5
formatting
cwpearson Mar 27, 2024
eb5a88e
Use default virtual dtor
cwpearson Mar 27, 2024
c237d59
Don't require void return type on Invokable
cwpearson Mar 27, 2024
e1ce0b5
Keep irecv view alive until wait
cwpearson Mar 27, 2024
2730595
Formatting docs/design.rst
cwpearson Mar 28, 2024
5e09b95
Formatting docs/design.rst
cwpearson Mar 28, 2024
3849c9a
Formatting docs/design.rst
cwpearson Mar 28, 2024
3037006
Irecv: fix include ordering
cwpearson Apr 5, 2024
536711b
irecv: remove mdspan
cwpearson Apr 10, 2024
6898850
irecv: remove mdspan tests
cwpearson Apr 10, 2024
1766ae5
irecv: test utility to make different kinds of views
cwpearson Apr 10, 2024
f75daab
view_builder.hpp: formatting
cwpearson Apr 10, 2024
b427737
irecv: add 2d view tests
cwpearson Apr 10, 2024
123d36a
design.rst: fix bullet list formatting
cwpearson May 8, 2024
b9a1b63
core.rst: fix MPI ops table
cwpearson May 8, 2024
4b76cfa
test_isendirecv: factor out common code
cwpearson May 8, 2024
c79e931
design.rst: drop mdspan-related reference
cwpearson May 8, 2024
1a1d649
Restrict KokkosComm::Req interface through pimpl
cwpearson May 8, 2024
2348031
newlines
cwpearson May 8, 2024
61bbc24
core.rst: remove non-existent Req members
cwpearson May 8, 2024
b73339c
improve comments on Impl::Req
cwpearson May 8, 2024
8090c57
Clarify async / fencing behavior of isend
cwpearson May 8, 2024
2fbfc59
space fencing in requests
cwpearson May 8, 2024
dcb918e
irecv: update wait semantics
cwpearson May 10, 2024
442458d
irecv: clang-format-14
cwpearson May 10, 2024
7f47397
irecv: fix some goofed types
cwpearson May 10, 2024
7a404e2
irecv: docs
cwpearson May 10, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
unit_tests: enable IsendIrecv mdspan tests
  • Loading branch information
cwpearson committed May 10, 2024
commit 1c5859f10a212b07a086dc9c402ba26497d9ad1e
16 changes: 8 additions & 8 deletions unit_tests/test_isendirecv.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,6 @@ TYPED_TEST(IsendIrecv, 1D_noncontig) {
ASSERT_EQ(errs, 0);
}
}
#if 0

#if KOKKOSCOMM_ENABLE_MDSPAN

Expand All @@ -131,9 +130,10 @@ TYPED_TEST(IsendIrecv, 1D_mdspan_contig) {
dst, 0, MPI_COMM_WORLD);
req.wait();
} else if (1 == rank) {
int src = 0;
KokkosComm::recv(Kokkos::DefaultExecutionSpace(), a, src, 0,
MPI_COMM_WORLD);
int src = 0;
KokkosComm::Req req = KokkosComm::irecv(Kokkos::DefaultExecutionSpace(), a,
src, 0, MPI_COMM_WORLD);
req.wait();
int errs = 0;
for (size_t i = 0; i < a.extent(0); ++i) {
errs += (a[i] != ScalarType(i));
Expand Down Expand Up @@ -166,16 +166,16 @@ TYPED_TEST(IsendIrecv, 1D_mdspan_noncontig) {
dst, 0, MPI_COMM_WORLD);
req.wait();
} else if (1 == rank) {
int src = 0;
KokkosComm::recv(Kokkos::DefaultExecutionSpace(), a, src, 0,
MPI_COMM_WORLD);
int src = 0;
KokkosComm::Req req = KokkosComm::irecv(Kokkos::DefaultExecutionSpace(), a,
src, 0, MPI_COMM_WORLD);
req.wait();
int errs = 0;
for (size_t i = 0; i < a.extent(0); ++i) {
errs += (a[i] != ScalarType(i));
}
ASSERT_EQ(errs, 0);
}
}
#endif

#endif // KOKKOSCOMM_ENABLE_MDSPAN