[pull] master from cockroachdb:master #1390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
This applies the same fix that was made for test_demo_node_cmds in 015b29c. To check the liveness range, the test needs to switch to the system tenant, so a new shorthand was added for that. We also specify the demo password deterministically so that we can switch connections. Release note: None
149783: cli: unskip test_demo_multitenant r=rafiss a=rafiss This applies the same fix that was made for test_demo_node_cmds in 015b29c. To check the liveness range, the test needs to switch to the system tenant, so a new shorthand was added for that. We also specify the demo password deterministically so that we can switch connections. fixes #141942 Release note: None Co-authored-by: Rafi Shamim <rafi@cockroachlabs.com>
The test had comments that described the buggy behavior. bb61a22 fixed the bug, so the comment needed updating. Release note: None
There is another error that can occur when creating a table with an unknown type, so this commit teaches the workload to handle it. Release note: None
152031: multiregionccl: update comments in test after a bug was fixed r=rafiss a=rafiss The test had comments that described the buggy behavior. bb61a22 fixed the bug, so the comment needed updating. Epic: None Release note: None 152034: workload/schemachange: fix error code for unknown type r=rafiss a=rafiss There is another error that can occur when creating a table with an unknown type, so this commit teaches the workload to handle it. informs #150547 Release note: None Co-authored-by: Rafi Shamim <rafi@cockroachlabs.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.3)
Can you help keep this open source service alive? 💖 Please sponsor : )