Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added 85 minutes 73 chapters tutorial link #736

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

FurkanGozukara
Copy link

I think this is the most comprehensive ever tutorial made for Kohya

I think this is the most comprehensive ever tutorial made for Kohya
@Sj-Si
Copy link

Sj-Si commented Oct 24, 2023

First time I've seen a PR that was literally a self advertisement. Does this not seem a bit pretentious? Not only that but it is the first line in the Tips section. Man, what a laugh.

@FurkanGozukara
Copy link
Author

pull requests of readme is expected by developers sometimes to add tutorial links.

@Sj-Si
Copy link

Sj-Si commented Oct 25, 2023

"pull requests of readme is expected by developers sometimes to add tutorial links."

That is expected of maintainers of a repository. It is not expected that someone adds a link to their youtube channel and states "this is the best tutorial out there" (sneakily omitting the fact that you are the one who created it).

A better approach is to say something like:

I made a tutorial for this repository. I believe it could prove helpful to people. If you have the time to review it, it may be worth adding to the Tips section of the readme.

Think of it this way. If someone made a video reading through one of your research papers, would you want them trying to weasel their way to the top of the acknowledgements on your paper?

@csatoshii
Copy link

additionally, the video heavily focuses on the GUI repo by bmaltais.

@FurkanGozukara
Copy link
Author

additionally, the video heavily focuses on the GUI repo by bmaltais.

you know that GUI is just a wrapper of sd-scripts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants