Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added warning on training without captions #533

Merged
merged 4 commits into from
May 28, 2023
Merged

Conversation

TingTingin
Copy link
Contributor

@TingTingin TingTingin commented May 23, 2023

Added feature to add "." if missing in caption_extension
Added warning on training without captions
closes #487 (comment)

Added feature to add "." if missing in caption_extension
Added warning on training without captions
@kohya-ss
Copy link
Owner

Thank you for this! This will help many users. I will review and merge as soon as I have time.

Copy link
Owner

@kohya-ss kohya-ss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay of the review. I hope you will check it out.

library/train_util.py Show resolved Hide resolved
library/train_util.py Show resolved Hide resolved
I removed the sleep since it triggers per subset and if someone had a lot of subsets it would trigger multiple times
@kohya-ss kohya-ss changed the base branch from main to dev May 28, 2023 23:37
@kohya-ss kohya-ss merged commit 2429ac7 into kohya-ss:dev May 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning on training without tags
2 participants