Skip to content

Ensure that we delist the trigger session on exception in the BeforeSave cycle #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
koenbeuk merged 2 commits into from
Dec 11, 2022
Merged

Ensure that we delist the trigger session on exception in the BeforeSave cycle #169

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc50484
Ensure that we delist the trigger session on exception in the BeforeS…
koenbeuk Dec 10, 2022
6dce097
Ensure that we delist the trigger session on exception in the BeforeS…
koenbeuk Dec 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/EntityFrameworkCore.Triggered/Internal/TriggerSessionSaveChangesInterceptor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,14 +80,19 @@ public InterceptionResult<int> SavingChanges(DbContextEventData eventData, Inter

try
{

eventData.Context.ChangeTracker.AutoDetectChangesEnabled = false;

_triggerSession.RaiseBeforeSaveStartingTriggers();
_triggerSession.RaiseBeforeSaveTriggers();
_triggerSession.CaptureDiscoveredChanges();
_triggerSession.RaiseBeforeSaveCompletedTriggers();
}
catch
{
// We're aborting the SaveChanges call, delist the trigger session now
DelistTriggerSession(eventData);
throw;
}
finally
{
eventData.Context.ChangeTracker.AutoDetectChangesEnabled = defaultAutoDetectChangesEnabled;
Expand Down Expand Up @@ -118,6 +123,12 @@ public async ValueTask<InterceptionResult<int>> SavingChangesAsync(DbContextEven
_triggerSession.RaiseBeforeSaveCompletedTriggers();
await _triggerSession.RaiseBeforeSaveCompletedAsyncTriggers(cancellationToken).ConfigureAwait(false);
}
catch
{
// We're aborting the SaveChanges call, delist the trigger session now
DelistTriggerSession(eventData);
throw;
}
finally
{
eventData.Context.ChangeTracker.AutoDetectChangesEnabled = defaultAutoDetectChangesEnabled;
Expand Down