Introducting synchronous triggers. #161
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for synchronous triggers. As a result, existing triggers types are renamed to properly reflect their async nature. As an example, we now expose:
This PR will also introduce a proper synchronous path without async-over-sync. Calling
dbContext.SaveChanges()
will only call synchonous triggers. Both synchronous as well as asynchronous triggers are called when callingdbContext.SaveChangesAsync()
. We should consider warning the user whenSaveChanges()
are being called while asynchronous triggers exists.As a consequence of this change, the
TriggeredDbContext
base class has been removed.This PR will break things!