Risk using async trigger behind a sync SaveChanges() call?

[benmccallum]

Hey! We've still got plenty of sync SaveChanges() calls in our codebase that we're slowly getting rid of but it did make me wonder whether there's a risk to writing an async trigger behind a sync call.

Before we dive in fully we might need to eliminate all our legacy sync SaveChanges() calls.

[benmccallum]

cc: @anthony-keller

[koenbeuk]

@benmccallum

There is indeed a risk as calls to SaveChanges will invoke Triggers and wait for the results by blocking the caller thread. This will cause a deadlock when you're calling from a UI thread and potentially causes a deadlock when you're calling from a ThreadPool thread. The latter is possible but rare and will only occur when the load on the thread pool has been maxed out. Still, it may be safer to eliminate all sync calls to SaveChanges first.

Hope this helps!

[benmccallum]

Thanks @koenbeuk , good to know. I think I might make a concerted effort to async all our things to be sure.

It might be worth linking this issue from a disclaimer on the readme/docs if you think it warrants it.

[koenbeuk]

@benmccallum I'm open for that. Would you mind issuing a PR?