Fix eager includes not working #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Looks good, I am in general still somewhat concerned about corner cases that we haven't caught yet and otherwise a negative performance impact for doing query root rewrites. It would be great if we can at least cache and reuse the generated projectable select expression and give the user the ability to opt in/out of this feature altogether. I'm planning on diving back into the repo and get things cleaned up and ready to go for EF 8, will also look into this then. Thanks for your contribution! |
This was referenced Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this changes, doing:
resulted in a null Orders field. This fixes this issue.
This also fixes a bug where query rewriting would be disabled when it should not.