Conversation
…e encoding. Changed `Writer::writeFiltered` to use `stream_filter_prepend`.
rhl-jfm
approved these changes
Oct 2, 2024
Contributor
rhl-jfm
left a comment
rhl-jfm
left a comment
There was a problem hiding this comment.
Looks good!
I assume that the test fails without the code change (it is a proper regression test).
Contributor
Author
Yes, the test fails without the change. It does feel weird having tests without assertions but I just mirrored the other test in the file 😅 |
Contributor
|
You could maybe add a comment to that effect. Something like: $service->send($message); // Throws if we fail to speak valid SMTP |
| ); | ||
|
|
||
| $message = new Message( | ||
| new Address("blip@test.org", "Rasmus åh Schultz"), |
Contributor
There was a problem hiding this comment.
Oh, I was about so say something about being personal, but I see this is copy/pasted from mindplay's own test examples back in the day, so this is a self-mention, so all good. 😄
thomasnordahl-dk
approved these changes
Oct 3, 2024
vortrixs
changed the title
vortrixs
deleted the
21-quoted-printable-and-dot-stuffing-filters-applied-in-wrong-order
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.