Skip to content

Added missing return type to SMTPDotStuffingFilter::filter#16

Merged
vortrixs merged 1 commit intomasterfrom
patch-smtpdotstuffingfilter-return-type
Nov 23, 2022
Merged

Added missing return type to SMTPDotStuffingFilter::filter#16
vortrixs merged 1 commit intomasterfrom
patch-smtpdotstuffingfilter-return-type

Conversation

@vortrixs
Copy link
Contributor

Just triggered this error

During inheritance of php_user_filter: Uncaught ErrorException: Return type of Kodus\Mail\SMTP\SMTPDotStuffingFilter::filter($in, $out, &$consumed, $closing) should either be compatible with php_user_filter::filter($in, $out, &$consumed, bool $closing): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/projects/jourbox/vendor/kodus/mail/src/SMTP/SMTPDotStuffingFilter.php:38

No idea why the tests aren't failing since this filter is used every time a mail is send 😕

@vortrixs vortrixs self-assigned this Nov 23, 2022
@vortrixs vortrixs changed the title Added missing return type Added missing return type to SMTPDotStuffingFilter::filter Nov 23, 2022
@vortrixs vortrixs changed the title Added missing return type to SMTPDotStuffingFilter::filter Added missing return type to SMTPDotStuffingFilter::filter Nov 23, 2022
@vortrixs vortrixs merged commit 6935fd4 into master Nov 23, 2022
@vortrixs vortrixs deleted the patch-smtpdotstuffingfilter-return-type branch November 23, 2022 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants