Merged
Conversation
…is functional, but added a stopgap in case SSL is not configured correctly since the actual error message is garbled
emhan-jfm
approved these changes
Aug 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SecureSocketCest::sendSMTPMessageOverSecureSockethas been re-enabled since it is actually functional and passes with the right setup [1][1] For the test to pass the SMTP server needs to have a SSL certificate installed and the certificate also needs to be added into the client's trusted CA store ("client" in this case being the system PHP runs on). As such I've added a "stop gap" that skips the test if the connection fails.
This is might not be the best way, but it's tricky finding a clean solution because we are dealing with two types of failure here:
Long story short, I was able to make it pass by integrating https://github.com/rnwood/smtp4dev into my docker setup and doing some "openssl magic", but I'm not sure how easy it is to replicate in the test environment.