Update kite.go #218
Closed
Update kite.go #218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uuid.NewV4() return multi-value, ref [https://github.com/satori/go.uuid/blob/master/generator.go#L166]
|
@rjeczalik I should also note that, despite your recommendation to use "dep" in #217 , the very README of this repository recommends using "go get", causing most of this issue. Secondly, if so many people keep creating the same pull request that you keep closing, why haven't you fixed the issue yourself in the project you manage? |
|
Superseded by #221. |
rjeczalik
added a commit
to rjeczalik/kite
that referenced
this pull request
Jun 17, 2018
Closes koding#218. Closes koding#219. Closes koding#220.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uuid.NewV4() return multi-value, ref [https://github.com/satori/go.uuid/blob/master/generator.go#L166]